core: Make cog_modules_add_directory() honor COG_MODULEDIR #659
+60
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psaavedra
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
#659 makes this even more robust and allows to dont need to use the cog_init().
Ref: #655 (comment)
Move handling of the COG_MODULEDIR environment variable into the cog_modules_add_directory() function, fix the bug that skipped using the environment variable when cog_init() is not used, and improve robustness: - The path passed is checked to be a valid directory location. - The environment variable is checked only once for the whole execution of the process, the first time the function is called with a NULL argument. - The path in the environment variable is checked for validity as well. A warning is produced for invalid locations. - If either the environment variable or the compiled-in default path are used, it is considered that the "default" path was set, and will not be set again to avoid re-scanning directories unnecessarily. While at it, sprinkle comments on the code to explain the logic.
aperezdc
force-pushed
the
aperezdc/loader-robusteness
branch
from
8317e88
to
2c77ef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move handling of the
COG_MODULEDIRenvironment variable into thecog_modules_add_directory()function, fix the bug that skipped using the environment variable whencog_init()is not used, and improve robustness:NULLargument.While at it, sprinkle comments on the code to explain the logic.
This depends on changes from #655